Meeting 2023-11-20

Attendees

  • Markus
  • Yvonne
  • Moritz (Protocol done)
  • Adi (Protocol done)
  • Jannis (Protocol done)
  • Samuel

Not here:

  • Daniel (Protocol done)

Buddies

  • Moritz & Samuel
  • Adi & Daniel & Jannis

Agenda

  • 09:00 welcome, mood
  • buddy talk
  • Protocol: Samuel
  • Reinsaat.at, Paul
  • 0.3.6 release today?
  • terminology for UI:
    • left, right top/down toolbar (context)
    • toasts
    • status panel
    • no title attributes? #1061
    • Navigation Bar
  • tailwind CSS linter
  • write good code comments:
    • small functions
    • functions with design by contract
    • assertions
    • nicely written comments
    • rationale (Konva)
  • weekly tasks:
    • always review meeting notes afterwards
    • https://nextcloud.markus-raab.org/nextcloud/index.php/apps/polls/vote/27
  • sprint plan
  • outlook

Tasks for Everyone

To be done until Friday 24.11.2023:

  • vote for https://nextcloud.markus-raab.org/nextcloud/index.php/apps/polls/vote/27
  • buddy topic: code improvements, comments
  • do/update sprint plan
  • tailwind CSS linter (frontend) #1073

If possible/needed, do:

  • create/update issues/tests (behavior driven) as needed for future tasks
  • get current issues, PRs and use cases (UC) done
  • review of meeting PR https://github.com/ElektraInitiative/PermaplanT/pull/1072/files
  • do reviews of PRs in main repo and submissions
  • submit a (short) text in submissions

Individual Tasks

To be done until Friday 24.11.2023:

  • Jannis: push draft NC chat, PermaplanT: de+en plant names, (mehrjährige pflanzen, remove variety)
  • Samuel: reviews, help others, ranking/language/tooltips
  • Moritz: polygon, snap tests with Samuel
  • Adi: flaky tests, release

Not here:

  • Daniel: prepare for merges (timeline etc.), issues updates
  • Chris: scraper fertig, plants hierarchy+relations

Meeting Notes

release talk

Adi review of moritz PR for release merge tests and then 'Fix full plant name not shown. #1063'

Naming

  • Status Panel - Timeline

Linting have a look at tailwindcss eslint plugin and tailwindcss intellisense for VSCode

Code Comments

Sometimes useful to add rationales and link issues of external repos if that is the reason for a workaround.

Weekly tasks

Try to do all of the weekly tasks each week! Always look in meeting protocol what the tasks are.

What happened this week

Samuel: full page navbar for mobile, plant icon at cursor while planting (almost done), slider bugfix. Moritz: refactored/reworked base layer form Adi: some E2E seed tests implemented some are left for upcoming week