Code Review

  • for each code review, only pick about 3-7 guidelines you think are most important in this context
  • document which guidelines you chose
  • don't check for what could be automatically checked (create issues for how to improve linter etc.)

Most important criteria to check:

  • is the code (with comments) understandable or can it be simplified?
  • is clear which code is responsible?
  • are names intuitive, consistent and included to glossary?

According to our architecture it can be important:

  • is all data validated?
  • are checks done only once?
  • etc. (please read architecture)